Skip to content

Conversation

@luciorq
Copy link

@luciorq luciorq commented Nov 20, 2024

Context: r-devel/r-dev-day#76

Also related: r-devel/cran-cookbook/discussions/53

This Pull Request introduces two new auxiliary functions, isDefunct() and isDeprecated(), and also integrates them into checkS3methods() to handle deprecated and defunct methods.

The development of this feature was carried out under the guidance of @gmbecker and @lawremi.

@luciorq
Copy link
Author

luciorq commented Apr 1, 2025

Closing as this is already solved.

r-devel/r-dev-day#76

Kurt committed a variant of this patch in revision SVN r87570 with a small tweak today. He says:

I just committed a variant of the patch with c87570. Unfortunately, I
managed to commit too much in one commit, so the commit msg does not
give credit etc. Sorry.

The change looks a bit different as I re-used and enhanced exisiting
code, ensured to match PKG::.Deprecated and PKG::.Defunct when PKG is
base but not otherwise, and changed to filter at the end as ideally we
do get() calls to get the functions from their names as little as
possible.

@luciorq luciorq closed this Apr 1, 2025
@luciorq luciorq deleted the r-dev-day/issue-76 branch April 1, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants